Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal build documentation #9802

Merged

Conversation

alexcrichton
Copy link
Member

  • Use the C API as the example instead of the wasmtime CLI now that Cranelift can be disabled.
  • Update custom platform docs to talk about signals-based-traps.

* Use the C API as the example instead of the `wasmtime` CLI now that
  Cranelift can be disabled.
* Update custom platform docs to talk about `signals-based-traps`.
@alexcrichton alexcrichton requested a review from a team as a code owner December 12, 2024 16:15
@alexcrichton alexcrichton requested review from cfallin and removed request for a team December 12, 2024 16:15
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fitzgen fitzgen enabled auto-merge December 12, 2024 16:22
@fitzgen fitzgen added this pull request to the merge queue Dec 12, 2024
Merged via the queue into bytecodealliance:main with commit 5b84c89 Dec 12, 2024
42 checks passed
@alexcrichton alexcrichton deleted the update-custom-embedding-docs branch December 12, 2024 16:49
@@ -211,51 +209,52 @@ $ export CARGO_PROFILE_RELEASE_LTO=true
$ export CARGO_PROFILE_RELEASE_CODEGEN_UNITS=1
$ export CARGO_PROFILE_RELEASE_STRIP=debuginfo
$ export RUSTFLAGS="-Zlocation-detail=none"
$ cargo +nightly build --release --no-default-features --features run,disable-logging \
$ cargo +nightly build -p wasmtime-c-api --release --no-default-features --features disable-logging \
-Z build-std=std,panic_abort --target aarch64-apple-darwin \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton, missed a target update here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes

alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants