pulley: Get strings.wast test passing #9801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
requested review from
abrown and
fitzgen
and removed request for
a team
|
Note that this is currently based on #9797 |
alexcrichton
commented
Dec 12, 2024
| @@ -26,7 +26,7 @@ macro_rules! define_opcode { | |||
|
|
|||
| impl Opcode { | |||
| /// The value of the maximum defined opcode. | |||
| pub const MAX: u8 = define_opcode!( @max $( $name )* ) + 1; | |||
| pub const MAX: u8 = Opcode::ExtendedOp as u8; | |||
There was a problem hiding this comment.
This change was needed because otherwise we overran the recursion limit and rustc asked for a #![recursion_limit = "bigger"] value which I wanted to avoid so I switch this to using the final enum here instead.
There was a problem hiding this comment.
Might be an off by one here? Does this need a + 1?
There was a problem hiding this comment.
Double-checked, but this doesn't have the +1 for now. (it's at least the same as before)
fitzgen
approved these changes
Dec 12, 2024
Needed the `imul` CLIF instruction to get implemented so 32/64-bit multiplication have now been added. cc bytecodealliance#9783
alexcrichton
force-pushed
the
pulley-imul
branch
from
2487140 to
b9c3c67
Compare
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed the
imulCLIF instruction to get implemented so 32/64-bitmultiplication have now been added.
cc #9783