Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport release-23.0.0] Use cmake to build wasmtime-c-api (#9031) #9102

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

clason
Copy link

@clason clason commented Aug 10, 2024

  • Use cmake to build wasmtime-c-api

  • Properly expose features when building via cmake

  • Install all headers to same directory

  • Add vets

  • attempt to fix ci

  • Run all tests on CI

prtest:full

  • Set CARGO_BUILD_TARGET; add CMakeLists to package

  • Update comment on github action

  • Attempt to fix android build

  • Fix source dir modifications of c-api build

  • Re-add BINARY_DIR option

  • Fix build

  • Move header installation to a cmake script

Try to avoid dealing with cmake configuration/platforms/etc.

  • Tweak build of headers

  • Install headers in build dir for examples

  • Add cmake files to dist, fix header install dir


Co-authored-by: Alex Crichton [email protected]

* Use cmake to build wasmtime-c-api

* Properly expose features when building via cmake

* Install all headers to same directory

* Add vets

* attempt to fix ci

* Run all tests on CI

prtest:full

* Set CARGO_BUILD_TARGET; add CMakeLists to package

* Update comment on github action

* Attempt to fix android build

* Fix source dir modifications of c-api build

* Re-add BINARY_DIR option

* Fix build

* Move header installation to a cmake script

Try to avoid dealing with cmake configuration/platforms/etc.

* Tweak build of headers

* Install headers in build dir for examples

* Add cmake files to dist, fix header install dir

---------

Co-authored-by: Alex Crichton <[email protected]>
@clason clason requested review from a team as code owners August 10, 2024 13:03
@clason clason requested review from elliottt and removed request for a team August 10, 2024 13:03
@clason
Copy link
Author

clason commented Aug 10, 2024

Opened backport PRs for both the current and the upcoming release; let me know which (if any) you want to keep and I'll close the other one(s).

@clason clason changed the title Use cmake to build wasmtime-c-api (#9031) [backport release-23.0.0] Use cmake to build wasmtime-c-api (#9031) Aug 10, 2024
@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Aug 10, 2024
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton merged commit 0f1b57f into bytecodealliance:release-23.0.0 Aug 12, 2024
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants