Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe workflow for testing preview2 components #7292

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Describe workflow for testing preview2 components #7292

merged 2 commits into from
Oct 25, 2023

Conversation

cdmurph32
Copy link
Contributor

This is information that would have been very useful when I was implementing timezones. #6899

@cdmurph32 cdmurph32 requested a review from a team as a code owner October 19, 2023 15:49
@cdmurph32 cdmurph32 requested review from alexcrichton and removed request for a team October 19, 2023 15:49
@github-actions github-actions bot added the wasmtime:docs Issues related to Wasmtime's documentation label Oct 19, 2023
fitzgen
fitzgen reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add newlines between paragraphs and wrap to 80 columns as the rest of the document does?

@alexcrichton alexcrichton requested review from fitzgen and removed request for alexcrichton October 23, 2023 22:05
fitzgen
fitzgen approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Oct 25, 2023
Merged via the queue into bytecodealliance:main with commit 038ddfe Oct 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
wasmtime:docs Issues related to Wasmtime's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmurph32 @fitzgen