Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specified type for V128AnyTrue #2658

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Specified type for V128AnyTrue #2658

merged 1 commit into from
Feb 17, 2021

Conversation

Daniel-Liu-c0deb0t
Copy link
Contributor

This was causing an issue in the stdarch WASM CI (rust-lang/stdarch#1004 (comment)). I'm assuming that V128AnyTrue was mistakenly not added in the type_of function, because all the other operators are there. If this was intentional, please let me know.

abrown
abrown approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@abrown abrown left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good fix; it looks like #2594 left out this line when switching from [I8x16|I16x8|I32x4]AnyTrue to V128AnyTrue.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:wasm labels Feb 16, 2021
@pchickey pchickey merged commit 38b63f5 into bytecodealliance:main Feb 17, 2021
@alexcrichton alexcrichton mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown abrown approved these changes

Assignees
No one assigned
Labels
cranelift:wasm cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-Liu-c0deb0t @abrown @pchickey