Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement real jump tables #16

Closed
pepyakin opened this issue Sep 4, 2018 · 3 comments
Closed

Implement real jump tables #16

pepyakin opened this issue Sep 4, 2018 · 3 comments

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Sep 4, 2018

There is this panic

https://github.com/CraneStation/wasmtime/blob/c5f0cd7d5e350afe4dd2d18e8efc009ad7f1eae3/lib/environ/src/compilation.rs#L66-L73

what is this about? I've tried to use a simple br_table with a few arms and it seems to work fine.
@sunfishcode
Copy link
Member

br_table is currently implemented by lowering it into a bunch of conditional branches. #453 is working on implementing it with an actual jump table.

@pepyakin
Copy link
Contributor Author

pepyakin commented Sep 4, 2018

Cool, thanks for the info! So then we need to implement relocating jump tables after they land in cranelift: bytecodealliance/cranelift#453.

I will update this issue and #14

@pepyakin pepyakin changed the title Are jump tables implemented? Implement real jump tables Sep 4, 2018
@pepyakin pepyakin mentioned this issue Sep 4, 2018
Closed
kubkon pushed a commit that referenced this issue Nov 7, 2019
@marmistrz @kubkon
Implement path_filestat_set_times using nix instead of libc.
065fbea 
As advised in #16.
@pepyakin
Copy link
Contributor Author

I believe this is implemented.

kubkon pushed a commit to kubkon/wasmtime that referenced this issue Mar 11, 2020
@pchickey
Merge pull request bytecodealliance#16 from kubkon/pch/factor_tests
3be9d48 
Start factoring tests
grishasobol pushed a commit to grishasobol/wasmtime that referenced this issue Nov 29, 2021
@pepyakin @NikVolf
Fix fuzz (bytecodealliance#35)
eda4882 
* Add checking for fuzz.

* Use wabt's validation instead of wasm2wat.

Fixes bytecodealliance#16
Fixes bytecodealliance#34

* Check fuzz with nightly.

* Install nightly toolchain

* Travis Driven Development bytecodealliance#1

* Travis Driven Development bytecodealliance#2
dhil added a commit to dhil/wasmtime that referenced this issue Apr 10, 2023
@dhil
Merge pull request bytecodealliance#16 from dhil/typed-continuations-new
4d84c9a 
Rebase typed continuations on effect-handlers/function-references
pchickey pushed a commit to pchickey/wasmtime that referenced this issue May 12, 2023
@alexcrichton
Implement args_{get,sizes_get} functions (bytecodealliance#16)
b541187 
This commit updates the implementation of `cabi_export_realloc` to
allocate from a bump-allocated-region in `State` rather than allocating
a separate page for each argument as previously done. Additionally the
argument data is now stored within `State` as well enabling a full
implementation of the `args_get` and `args_sizes_get` syscalls.
pchickey pushed a commit to pchickey/wasmtime that referenced this issue May 16, 2023
@alexcrichton
Implement args_{get,sizes_get} functions (bytecodealliance#16)
43dfe3b 
This commit updates the implementation of `cabi_export_realloc` to
allocate from a bump-allocated-region in `State` rather than allocating
a separate page for each argument as previously done. Additionally the
argument data is now stored within `State` as well enabling a full
implementation of the `args_get` and `args_sizes_get` syscalls.
dhil added a commit to dhil/wasmtime that referenced this issue Sep 29, 2023
@dhil
Merge pull request bytecodealliance#16 from dhil/wasmfx-merge
ab5d997 
Weekly merge with upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pepyakin @sunfishcode