threads: add thread.spawn_indirect
#2042
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in [bytecodealliance#89], this adds support for a new intrinsic, `thread.spawn_indirect`. This new operation would allow spawning a shared function stored in a table via a table index. This leaves some future work undone: - `thread.spawn` could/should be renamed to `thread.spawn_ref` - `thread.spawn_indirect` could/should take the encoding byte from `thread.hw_concurrency`--swap `0x07` for `0x06` - importantly, `thread.spawn_indirect` should gain a field indicating which type to expect in the indirect table; due to current limitations in `wasm-tools`, the locations to check once this is possible are marked with `TODO: spawn indirect types`. [bytecodealliance#89]: WebAssembly/shared-everything-threads#89
This encoding change is necessary due to recent additions to the component model; see [bytecodealliance#447]. [bytecodealliance#447]: WebAssembly/component-model#447
[bytecodealliance#447] tries to make the built-in naming a bit more consistent; this change propagates that here. [bytecodealliance#447]: WebAssembly/component-model#447
abrown
force-pushed
the
set-spawn-indirect
branch
from
cfc0969 to
7d7f530
Compare
alexcrichton
reviewed
Feb 9, 2025
Comment on lines
+288
to
+290
| 0x24 => CanonicalFunction::ThreadSpawnIndirect { | ||
| table_index: reader.read()?, | ||
| }, |
There was a problem hiding this comment.
This makes sense logically to put here but for easily scanning this list mind moving it down to the bottom so it's more clear where the "holes" are in decoding?
Comment on lines
+391
to
+394
| // Eventually this should resolve the specific type associated | ||
| // with this canonical function, e.g., | ||
| // `self.resolve_type_use(&mut info.ty)?;` (TODO: spawn indirect | ||
| // types). |
There was a problem hiding this comment.
Adding a comment to flag this. This looks though like it's a TODO at the spec-level, right? (as opposed to just exclusively the implementation here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propagates the upstream spec changes to the component model in #447 here. See commit messages for more details.