Remove quadratic behavior cloning rec groups #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `clone_rec_group` would create a new vector each time it was called of all clonable rec groups where if an empty rec group is cloned this creates quadratic behavior where each time a vector is created and one more item is appended. The fix in this commit is to avoid creating a precise set of candidates to clone and just throwing out candidates that aren't applicable.
fitzgen
approved these changes
Dec 16, 2024
mjoerussell
pushed a commit
to manastech/wasm-tools
that referenced
this pull request
Dec 17, 2024
The call to `clone_rec_group` would create a new vector each time it was called of all clonable rec groups where if an empty rec group is cloned this creates quadratic behavior where each time a vector is created and one more item is appended. The fix in this commit is to avoid creating a precise set of candidates to clone and just throwing out candidates that aren't applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
clone_rec_groupwould create a new vector each time it was called of all clonable rec groups where if an empty rec group is cloned this creates quadratic behavior where each time a vector is created and one more item is appended.The fix in this commit is to avoid creating a precise set of candidates to clone and just throwing out candidates that aren't applicable.