Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase limits of some component types #1713

Merged

Conversation

alexcrichton
Copy link
Member

Increase some limits from 1_000 to 10_000 to handle bytecodealliance/wit-bindgen#1019

Increase some limits from 1_000 to 10_000 to handle
bytecodealliance/wit-bindgen#1019
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we clamp flags to 32 or 64 elsewhere?

@alexcrichton
Copy link
Member Author

Good point, I'll leave that limit as-is. The validation limit per-definition for some of these is smaller as well.

@alexcrichton alexcrichton enabled auto-merge August 8, 2024 07:25
@alexcrichton alexcrichton added this pull request to the merge queue Aug 8, 2024
Merged via the queue into bytecodealliance:main with commit 3e14e8e Aug 8, 2024
28 checks passed
@alexcrichton alexcrichton deleted the increase-some-limits branch August 8, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants