-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept f32
/f64
as aliases for float32
/float64
.
#1356
Accept f32
/f64
as aliases for float32
/float64
.
#1356
Conversation
In WebAssembly/component-model#277 there seems to be consensus emerging to rename `float32`/`float64` to `f32`/`f64`. This PR just adds support for parsing `f32`/`f64`, and changes nothing else for now, to start preparing for this change.
Before committing to this could a rough plan of how to make this transition be written down first? I suspect it'd look pretty similar to other historical transition plans, but it'd be good to have it in words somewhere. I'm retroactively wishing we had a list of active transitions happening at any one point in time because I've long forgotten what's needed any more at this point, but that can be handled later. Can you additionally add some tests which assert that the syntax parses and works correctly? |
Maybe we could get the I think they're the main changes and we can probably try to synchronize them to some extent. |
A plan for
The other transition in flight is documentation comments. That one's simpler because wit-parser already accepts
The semicolon transition is already done. Wit-parser is already requiring semicolons. Do these look reasonable? If so, I can file new issues in this repo to track them.
I've now added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, and thanks! And yeah if you wouldn't mind opening issues that's probably the best way to track things for now.
Like with //
as well this is probably a good time to go ahead and implement wearnings for float{32,64}
and just have them disabled by default until we decide to turn them on.
In WebAssembly/component-model#277 there seems to be consensus emerging to rename
float32
/float64
tof32
/f64
. This PR just adds support for parsingf32
/f64
, and changes nothing else for now, to start preparing for this change.