switched to log::debug! from println! for plug subcommand; skippe…

…d using the progress bar output when only one thing to do
bytecodealliance · May 13, 2024 · e28403e · e28403e
1 parent dc3081f
commit e28403e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/crates/wac-resolver/src/registry.rs b/crates/wac-resolver/src/registry.rs
@@ -86,7 +86,6 @@ impl RegistryPackageResolver {
 
         // fetch required package logs and return error if any not found
         if let Some(bar) = self.bar.as_ref() {
-            bar.init(1);
             bar.println("Updating", "package logs from the registry");
         }
 
@@ -108,9 +107,6 @@ impl RegistryPackageResolver {
         }
 
         if let Some(bar) = self.bar.as_ref() {
-            bar.inc(1);
-            bar.finish();
-
             // download package content if not in cache
             bar.init(keys.len());
             bar.println("Downloading", "package content from the registry");

diff --git a/src/commands/plug.rs b/src/commands/plug.rs
@@ -112,7 +112,7 @@ impl PlugCommand {
 
                 if let Some(ver) = version {
                     let download = client.download_exact(name, ver).await?;
-                    println!(
+                    log::debug!(
                         "Plugging `{name}` version `{ver}` using registry `{registry}`",
                         registry = client.url()
                     );
@@ -123,7 +123,7 @@ impl PlugCommand {
                         .await?
                         .ok_or_else(|| anyhow::anyhow!("package `{name}` was not found"))?;
 
-                    println!(
+                    log::debug!(
                         "Plugging `{name}` version `{ver}` using registry `{registry}`",
                         ver = &download.version,
                         registry = client.url()
@@ -132,7 +132,7 @@ impl PlugCommand {
                 }
             }
             PackageRef::LocalPath(path) => {
-                println!("Plugging `{path}`", path = path.display());
+                log::debug!("Plugging `{path}`", path = path.display());
 
                 path.clone()
             }
@@ -178,7 +178,7 @@ impl PlugCommand {
 
                         let path = if let Some(ver) = version {
                             let download = client.download_exact(name, ver).await?;
-                            println!(
+                            log::debug!(
                                 "    with `{name}` version `{ver}` using registry `{registry}`",
                                 registry = client.url()
                             );
@@ -189,7 +189,7 @@ impl PlugCommand {
                                 .await?
                                 .ok_or_else(|| anyhow::anyhow!("package `{name}` was not found"))?;
 
-                            println!(
+                            log::debug!(
                                 "    with `{name}` version `{ver}` using registry `{registry}`",
                                 ver = &download.version,
                                 registry = client.url()
@@ -201,7 +201,7 @@ impl PlugCommand {
                         (name, path)
                     }
                     PackageRef::LocalPath(path) => {
-                        println!("    with `{path}`", path = path.display());
+                        log::debug!("    with `{path}`", path = path.display());
                         (format!("plug:{name}"), path.clone())
                     }
                 };
@@ -252,7 +252,7 @@ impl PlugCommand {
                     "failed to write output file `{path}`",
                     path = path.display()
                 ))?;
-                println!("\nWrote plugged component: `{path}`", path = path.display());
+                log::debug!("\nWrote plugged component: `{path}`", path = path.display());
             }
             None => {
                 std::io::stdout()