Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make download_content public in Client. #234

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Make download_content public in Client. #234

merged 1 commit into from
Dec 3, 2023

Conversation

peterhuene
Copy link
Member

This PR makes download_content a public function from Client.

It turns out that this is a useful function to have for clients that can determine missing content hashes from the client storage and instruct the client to download just the content.

calvinrp
calvinrp reviewed Dec 2, 2023
View reviewed changes
crates/client/src/lib.rs Outdated Show resolved Hide resolved
@calvinrp calvinrp self-requested a review December 2, 2023 16:16
calvinrp
calvinrp approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@calvinrp calvinrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but might be good to fix the cargo fmt issue before merging.

@peterhuene peterhuene merged commit 351df67 into bytecodealliance:main Dec 3, 2023
6 checks passed
@peterhuene peterhuene deleted the make-pub branch December 3, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinrp calvinrp calvinrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhuene @calvinrp