Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitors and federation server side #225

Merged

Conversation

calvinrp
Copy link
Collaborator

@calvinrp calvinrp commented Nov 8, 2023

@calvinrp calvinrp requested review from lann and esoterra November 8, 2023 19:22
@calvinrp
Copy link
Collaborator Author

calvinrp commented Nov 9, 2023

TODO:

  • more tests
  • validation on package publish for operator log defined namespaces
  • adding new permissions for defining and importing namespaces

The client-side will largely be done in a separate PR. Also, I'll have a separate PR for #229 , to avoid a really messy diff in this PR.

But helpful to start reviewing...

crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/protocol/src/operator/state.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review covering the api crate changes

crates/api/src/v1/ledger.rs Outdated Show resolved Hide resolved
crates/api/src/v1/ledger.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
@calvinrp
Copy link
Collaborator Author

Refactored the verify checkpoint endpoint. The OpenAPI rendered spec

crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Outdated Show resolved Hide resolved
crates/api/src/v1/monitor.rs Show resolved Hide resolved
crates/protocol/src/operator/state.rs Outdated Show resolved Hide resolved
crates/protocol/src/operator/state.rs Show resolved Hide resolved
crates/server/src/api/v1/mod.rs Outdated Show resolved Hide resolved
crates/server/src/api/v1/monitor.rs Outdated Show resolved Hide resolved
@calvinrp calvinrp merged commit a233eb4 into bytecodealliance:main Nov 16, 2023
6 checks passed
@calvinrp calvinrp deleted the monitors-and-federation-server-side branch November 16, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants