Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing serde flatten #200

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

calvinrp
Copy link
Collaborator

This fixes a mismatch between the intended JSON schema, described in the OpenAPI spec, and the implementation.

@calvinrp calvinrp requested review from lann and peterhuene September 25, 2023 19:20
@calvinrp calvinrp self-assigned this Sep 25, 2023
@lann
Copy link
Collaborator

lann commented Sep 25, 2023

If we have other breaking protocol changes coming down the pipe lets wait to merge this to avoid needing another client/server upgrade sync.

@calvinrp
Copy link
Collaborator Author

If we have other breaking protocol changes coming down the pipe lets wait to merge this to avoid needing another client/server upgrade sync.

Yep, do you think I should combine all the changes in the same PR?

@esoterra
Copy link
Collaborator

We could also put them on main but not cut a release or retarget this PR to a release candidate branch and do the same for other proposed changes (maybe even make it a 0.2 branch?).

@calvinrp
Copy link
Collaborator Author

Now that we resolved the release process, should we approve and merge this PR? Or should it be lumped into an upcoming PR that has other unrelated breaking changes.

@esoterra
Copy link
Collaborator

I'm not familiar with the context for this flatten, so I'll let Lann review, but I think now that we've got the process sorted this shouldn't be considered blocked

@calvinrp calvinrp merged commit 12dfea5 into bytecodealliance:main Sep 27, 2023
@calvinrp calvinrp deleted the flatten branch September 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants