Respect build target from cargo config #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinrp
approved these changes
Jul 9, 2024
|
Sorry, it took a few days to get to this one. Thank you for the PR. |
mergify bot
referenced
this pull request
in andrzejressel/pulumi-wasm
Jul 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cargo-component](https://togithub.com/bytecodealliance/cargo-component) | minor | `0.13.0` -> `0.14.0` | --- ### Release Notes <details> <summary>bytecodealliance/cargo-component (cargo-component)</summary> ### [`v0.14.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.14.0) [Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.2...v0.14.0) #### What's Changed - Document additional `cargo-component` requirements by [@​yoshuawuyts](https://togithub.com/yoshuawuyts) in [https://github.com/bytecodealliance/cargo-component/pull/309](https://togithub.com/bytecodealliance/cargo-component/pull/309) - Update adapter builds by [@​alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/312](https://togithub.com/bytecodealliance/cargo-component/pull/312) - Rename `wasm32-wasi` to `wasm32-wasip1` by [@​alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/313](https://togithub.com/bytecodealliance/cargo-component/pull/313) - Update to -S cli instead of -S common for wasmtime commands by [@​iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/317](https://togithub.com/bytecodealliance/cargo-component/pull/317) - Respect build target from cargo config by [@​iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/319](https://togithub.com/bytecodealliance/cargo-component/pull/319) #### New Contributors - [@​yoshuawuyts](https://togithub.com/yoshuawuyts) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/309](https://togithub.com/bytecodealliance/cargo-component/pull/309) - [@​iawia002](https://togithub.com/iawia002) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/317](https://togithub.com/bytecodealliance/cargo-component/pull/317) **Full Changelog**: bytecodealliance/cargo-component@v0.13.2...v0.14.0 ### [`v0.13.2`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.2) [Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2) #### What's Changed - Add `cargo component serve` subcommand by [@​primoly](https://togithub.com/primoly) in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305) - added wasmtime wasi args for `cargo component serve` by [@​calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/308](https://togithub.com/bytecodealliance/cargo-component/pull/308) #### New Contributors - [@​primoly](https://togithub.com/primoly) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305) **Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2 ### [`v0.13.1`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.1) [Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1) #### What's Changed - More `cargo component new` generator fixes by [@​calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/304](https://togithub.com/bytecodealliance/cargo-component/pull/304) **Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
](https://renovatebot.com){kind=link}
|
Am I missing something? In my components [build]
target = "wasm32-unknown-unknown"but it still defauts to |
|
The path to cargo configuration should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reads the project's Cargo configuration and uses the build target specified in it. This ensures that
cargo component buildwill respect the target configuration in the.cargo/config.tomlfile and the value of theCARGO_BUILD_TARGETenvironment variable.close #106
close #290
cc @calvinrp