Stop generating the bindings file for projects without wit files and dependencies #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you recommend a good way to test locally? |
|
Sure, a common scenario is using wasi-rs directly to build wasm programs. In this case, we directly reference the bindings generated by wasi-rs and do not have our wit files. In this scenario, an "empty" bindings file should not be generated. Another scenario is directly using a wasm http client library such as waki. We don't have our own wit files, but an "empty" bindings file is generated. You can directly use the code of the above two examples to test it locally. |
calvinrp
approved these changes
Jul 31, 2024
mergify bot
referenced
this pull request
in andrzejressel/pulumi-wasm
Jul 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cargo-component](https://togithub.com/bytecodealliance/cargo-component) | minor | `0.14.0` -> `0.15.0` | --- ### Release Notes <details> <summary>bytecodealliance/cargo-component (cargo-component)</summary> ### [`v0.15.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.15.0) [Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.14.0...v0.15.0) #### What's Changed - set dev version to 0.15.0-dev by [@​calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/320](https://togithub.com/bytecodealliance/cargo-component/pull/320) - Pull adapters from crates.io instead of vendoring by [@​alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/323](https://togithub.com/bytecodealliance/cargo-component/pull/323) - Stop generating the bindings file for projects without wit files and dependencies by [@​iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/318](https://togithub.com/bytecodealliance/cargo-component/pull/318) **Full Changelog**: bytecodealliance/cargo-component@v0.14.0...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such as the case described in #314.
cc @calvinrp
close #314