New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added wasmtime wasi args for `cargo component serve` #308

Merged

calvinrp merged 1 commit into main from fix-cargo-component-serve-args

Jun 1, 2024

Collaborator

calvinrp commented Jun 1, 2024

No description provided.


          added the wasmtime serve args for wasi support on the `cargo componen…

bb77a44

…t serve` command

calvinrp requested review from fibonacci1729 and macovedj

June 1, 2024 15:58

fibonacci1729 approved these changes

View reviewed changes

calvinrp merged commit d859e93 into main

6 checks passed

calvinrp deleted the fix-cargo-component-serve-args branch

June 1, 2024 20:43

FrankReh reviewed

View reviewed changes

src/lib.rs

@@ @@ -274,7 +274,7 @@ fn get_runner(serve: bool) -> Result<PathAndArgs> { @@
                           (
                               PathAndArgs::new("wasmtime")
                                   .args(if serve {
-                                      vec!["serve"]
+                                      vec!["serve", "-S", "common", "-S", "http"]

FrankReh Jun 2, 2024

I think "common" is being deprecated. Too early to use "cli"?

Collaborator Author

calvinrp Jun 3, 2024

Yeah, good catch. I have an issue to track making that change: #306

It was recently failing CI tests switching to "cli" instead of "common". Need to track down why it is still grabbing an older release of wasmtime.

mergify bot referenced this pull request in andrzejressel/pulumi-gestalt


          chore(deps): update dependency cargo-component to 0.13.0 (#197)

59620f7

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cargo-component](https://togithub.com/bytecodealliance/cargo-component) | minor | `0.10.1` -> `0.13.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/cargo-component (cargo-component)</summary>

### [`v0.13.2`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.2)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2)

#### What's Changed

-   Add `cargo component serve` subcommand by [@&#8203;primoly](https://togithub.com/primoly) in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)
-   added wasmtime wasi args for `cargo component serve` by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/308](https://togithub.com/bytecodealliance/cargo-component/pull/308)

#### New Contributors

-   [@&#8203;primoly](https://togithub.com/primoly) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2

### [`v0.13.1`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.1)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1)

#### What's Changed

-   More `cargo component new` generator fixes by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/304](https://togithub.com/bytecodealliance/cargo-component/pull/304)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1

### [`v0.13.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.12.0...v0.13.0)

#### What's Changed

-   set dev version by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/297](https://togithub.com/bytecodealliance/cargo-component/pull/297)
-   Bug fixes for targeting a world with resource borrows by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/300](https://togithub.com/bytecodealliance/cargo-component/pull/300)

**Full Changelog**: bytecodealliance/cargo-component@v0.12.0...v0.13.0

### [`v0.12.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.12.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.11.0...v0.12.0)

#### What's Changed

-   add support for missing settings from wit-bindgen by [@&#8203;sehnryr](https://togithub.com/sehnryr) in [https://github.com/bytecodealliance/cargo-component/pull/273](https://togithub.com/bytecodealliance/cargo-component/pull/273)
-   fix kebab case issue by [@&#8203;fibonacci1729](https://togithub.com/fibonacci1729) in [https://github.com/bytecodealliance/cargo-component/pull/274](https://togithub.com/bytecodealliance/cargo-component/pull/274)
-   Help mesasage improvement ([#&#8203;138](https://togithub.com/bytecodealliance/cargo-component/issues/138)) by [@&#8203;chikoski](https://togithub.com/chikoski) in [https://github.com/bytecodealliance/cargo-component/pull/278](https://togithub.com/bytecodealliance/cargo-component/pull/278)
-   Update the example to use the latest version of cargo-component by [@&#8203;rylev](https://togithub.com/rylev) in [https://github.com/bytecodealliance/cargo-component/pull/283](https://togithub.com/bytecodealliance/cargo-component/pull/283)
-   fix test assertions after rust upgrade by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/287](https://togithub.com/bytecodealliance/cargo-component/pull/287)
-   Add `profile.release` to `Cargo.toml` generated by `cargo component new` by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/289](https://togithub.com/bytecodealliance/cargo-component/pull/289)
-   Update install instruction to use --locked by [@&#8203;fibonacci1729](https://togithub.com/fibonacci1729) in [https://github.com/bytecodealliance/cargo-component/pull/292](https://togithub.com/bytecodealliance/cargo-component/pull/292)
-   Update to latest Warg release to support registry federation by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/288](https://togithub.com/bytecodealliance/cargo-component/pull/288)
-   removed unused warg-credentials dependency by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/295](https://togithub.com/bytecodealliance/cargo-component/pull/295)
-   Warg update 0.7 by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/296](https://togithub.com/bytecodealliance/cargo-component/pull/296)

#### New Contributors

-   [@&#8203;sehnryr](https://togithub.com/sehnryr) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/273](https://togithub.com/bytecodealliance/cargo-component/pull/273)
-   [@&#8203;fibonacci1729](https://togithub.com/fibonacci1729) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/274](https://togithub.com/bytecodealliance/cargo-component/pull/274)
-   [@&#8203;chikoski](https://togithub.com/chikoski) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/278](https://togithub.com/bytecodealliance/cargo-component/pull/278)
-   [@&#8203;calvinrp](https://togithub.com/calvinrp) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/287](https://togithub.com/bytecodealliance/cargo-component/pull/287)

**Full Changelog**: bytecodealliance/cargo-component@v0.11.0...v0.12.0

### [`v0.11.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.11.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.10.1...v0.11.0)

#### Compatibility

-   Wasmtime: 17.0.0+
-   WASI: 0.2.0
-   Warg (registry support): 0.4.0

#### What's Changed

-   Update wit-bindgen and wasm-tools. by [@&#8203;sunfishcode](https://togithub.com/sunfishcode) in [https://github.com/bytecodealliance/cargo-component/pull/266](https://togithub.com/bytecodealliance/cargo-component/pull/266)
-   Synchronize artifact componentization.  by [@&#8203;peterhuene](https://togithub.com/peterhuene) in [https://github.com/bytecodealliance/cargo-component/pull/270](https://togithub.com/bytecodealliance/cargo-component/pull/270)
-   Bump version to 0.11.0. by [@&#8203;peterhuene](https://togithub.com/peterhuene) in [https://github.com/bytecodealliance/cargo-component/pull/271](https://togithub.com/bytecodealliance/cargo-component/pull/271)

**Full Changelog**: bytecodealliance/cargo-component@v0.10.1...v0.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).

mergify bot referenced this pull request in andrzejressel/pulumi-gestalt


          chore(deps): update dependency cargo-component to 0.14.0 (#223)

4192fa5

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cargo-component](https://togithub.com/bytecodealliance/cargo-component) | minor | `0.13.0` -> `0.14.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/cargo-component (cargo-component)</summary>

### [`v0.14.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.14.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.2...v0.14.0)

#### What's Changed

-   Document additional `cargo-component` requirements by [@&#8203;yoshuawuyts](https://togithub.com/yoshuawuyts) in [https://github.com/bytecodealliance/cargo-component/pull/309](https://togithub.com/bytecodealliance/cargo-component/pull/309)
-   Update adapter builds by [@&#8203;alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/312](https://togithub.com/bytecodealliance/cargo-component/pull/312)
-   Rename `wasm32-wasi` to `wasm32-wasip1` by [@&#8203;alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/313](https://togithub.com/bytecodealliance/cargo-component/pull/313)
-   Update to -S cli instead of -S common for wasmtime commands by [@&#8203;iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/317](https://togithub.com/bytecodealliance/cargo-component/pull/317)
-   Respect build target from cargo config by [@&#8203;iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/319](https://togithub.com/bytecodealliance/cargo-component/pull/319)

#### New Contributors

-   [@&#8203;yoshuawuyts](https://togithub.com/yoshuawuyts) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/309](https://togithub.com/bytecodealliance/cargo-component/pull/309)
-   [@&#8203;iawia002](https://togithub.com/iawia002) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/317](https://togithub.com/bytecodealliance/cargo-component/pull/317)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.2...v0.14.0

### [`v0.13.2`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.2)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2)

#### What's Changed

-   Add `cargo component serve` subcommand by [@&#8203;primoly](https://togithub.com/primoly) in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)
-   added wasmtime wasi args for `cargo component serve` by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/308](https://togithub.com/bytecodealliance/cargo-component/pull/308)

#### New Contributors

-   [@&#8203;primoly](https://togithub.com/primoly) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2

### [`v0.13.1`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.1)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1)

#### What's Changed

-   More `cargo component new` generator fixes by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/304](https://togithub.com/bytecodealliance/cargo-component/pull/304)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet