New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `cargo component serve` subcommand #305

Merged

calvinrp merged 2 commits into bytecodealliance:main from primoly:serve

May 28, 2024

Contributor

primoly commented May 27, 2024

Adds a serve subcommand to cargo component invoking wasmtime serve.

Also updates the -S common option to -S cli (bytecodealliance/wasmtime#8166).

I haven’t added any tests because I’m not sure how to verify the serving of a wasi:http component.

Closes #276


          add serve subcommand

c5b0f1d

calvinrp reviewed

View reviewed changes

src/lib.rs Outdated

+                                  .args(if serve {
+                                      vec!["serve"]
+                                  } else {
+                                      vec!["-S", "preview2", "-S", "cli"]

Collaborator

calvinrp May 27, 2024

Change this back to vec!["-S", "preview2", "-S", "common"]? "common" vs "cli"

I always struggle to find the docs for these -S flags. But the CI is failing error: unknown -S / --wasi option: cli

Contributor Author

primoly May 27, 2024

The cli option was introduced in Wasmtime 20, but the CI is using Wasmtime 19.0.2
I reverted the change, but the release notes state that -S common will be deprecated in the future^[1], so cargo component should make that switch eventually.

[1] https://github.com/bytecodealliance/wasmtime/blob/release-20.0.0/RELEASES.md#changed

Collaborator

calvinrp May 28, 2024

Ah, good catch. Created an issue to track and change this in the future.


          change back from cli to common

5bc2358

calvinrp mentioned this pull request

Update to -S cli instead of -S common for wasmtime commands #306

Closed

calvinrp approved these changes

View reviewed changes

calvinrp merged commit 10b14fb into bytecodealliance:main

6 checks passed

Collaborator

calvinrp commented May 28, 2024

Thank you!

sunfishcode mentioned this pull request

Use cargo component serve? sunfishcode/hello-wasi-http#14

Closed

yoshuawuyts mentioned this pull request

How to use cargo component serve? #311

Closed

mergify bot referenced this pull request in andrzejressel/pulumi-gestalt


          chore(deps): update dependency cargo-component to 0.13.0 (#197)

59620f7

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cargo-component](https://togithub.com/bytecodealliance/cargo-component) | minor | `0.10.1` -> `0.13.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/cargo-component (cargo-component)</summary>

### [`v0.13.2`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.2)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2)

#### What's Changed

-   Add `cargo component serve` subcommand by [@&#8203;primoly](https://togithub.com/primoly) in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)
-   added wasmtime wasi args for `cargo component serve` by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/308](https://togithub.com/bytecodealliance/cargo-component/pull/308)

#### New Contributors

-   [@&#8203;primoly](https://togithub.com/primoly) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2

### [`v0.13.1`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.1)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1)

#### What's Changed

-   More `cargo component new` generator fixes by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/304](https://togithub.com/bytecodealliance/cargo-component/pull/304)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1

### [`v0.13.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.12.0...v0.13.0)

#### What's Changed

-   set dev version by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/297](https://togithub.com/bytecodealliance/cargo-component/pull/297)
-   Bug fixes for targeting a world with resource borrows by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/300](https://togithub.com/bytecodealliance/cargo-component/pull/300)

**Full Changelog**: bytecodealliance/cargo-component@v0.12.0...v0.13.0

### [`v0.12.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.12.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.11.0...v0.12.0)

#### What's Changed

-   add support for missing settings from wit-bindgen by [@&#8203;sehnryr](https://togithub.com/sehnryr) in [https://github.com/bytecodealliance/cargo-component/pull/273](https://togithub.com/bytecodealliance/cargo-component/pull/273)
-   fix kebab case issue by [@&#8203;fibonacci1729](https://togithub.com/fibonacci1729) in [https://github.com/bytecodealliance/cargo-component/pull/274](https://togithub.com/bytecodealliance/cargo-component/pull/274)
-   Help mesasage improvement ([#&#8203;138](https://togithub.com/bytecodealliance/cargo-component/issues/138)) by [@&#8203;chikoski](https://togithub.com/chikoski) in [https://github.com/bytecodealliance/cargo-component/pull/278](https://togithub.com/bytecodealliance/cargo-component/pull/278)
-   Update the example to use the latest version of cargo-component by [@&#8203;rylev](https://togithub.com/rylev) in [https://github.com/bytecodealliance/cargo-component/pull/283](https://togithub.com/bytecodealliance/cargo-component/pull/283)
-   fix test assertions after rust upgrade by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/287](https://togithub.com/bytecodealliance/cargo-component/pull/287)
-   Add `profile.release` to `Cargo.toml` generated by `cargo component new` by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/289](https://togithub.com/bytecodealliance/cargo-component/pull/289)
-   Update install instruction to use --locked by [@&#8203;fibonacci1729](https://togithub.com/fibonacci1729) in [https://github.com/bytecodealliance/cargo-component/pull/292](https://togithub.com/bytecodealliance/cargo-component/pull/292)
-   Update to latest Warg release to support registry federation by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/288](https://togithub.com/bytecodealliance/cargo-component/pull/288)
-   removed unused warg-credentials dependency by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/295](https://togithub.com/bytecodealliance/cargo-component/pull/295)
-   Warg update 0.7 by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/296](https://togithub.com/bytecodealliance/cargo-component/pull/296)

#### New Contributors

-   [@&#8203;sehnryr](https://togithub.com/sehnryr) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/273](https://togithub.com/bytecodealliance/cargo-component/pull/273)
-   [@&#8203;fibonacci1729](https://togithub.com/fibonacci1729) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/274](https://togithub.com/bytecodealliance/cargo-component/pull/274)
-   [@&#8203;chikoski](https://togithub.com/chikoski) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/278](https://togithub.com/bytecodealliance/cargo-component/pull/278)
-   [@&#8203;calvinrp](https://togithub.com/calvinrp) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/287](https://togithub.com/bytecodealliance/cargo-component/pull/287)

**Full Changelog**: bytecodealliance/cargo-component@v0.11.0...v0.12.0

### [`v0.11.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.11.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.10.1...v0.11.0)

#### Compatibility

-   Wasmtime: 17.0.0+
-   WASI: 0.2.0
-   Warg (registry support): 0.4.0

#### What's Changed

-   Update wit-bindgen and wasm-tools. by [@&#8203;sunfishcode](https://togithub.com/sunfishcode) in [https://github.com/bytecodealliance/cargo-component/pull/266](https://togithub.com/bytecodealliance/cargo-component/pull/266)
-   Synchronize artifact componentization.  by [@&#8203;peterhuene](https://togithub.com/peterhuene) in [https://github.com/bytecodealliance/cargo-component/pull/270](https://togithub.com/bytecodealliance/cargo-component/pull/270)
-   Bump version to 0.11.0. by [@&#8203;peterhuene](https://togithub.com/peterhuene) in [https://github.com/bytecodealliance/cargo-component/pull/271](https://togithub.com/bytecodealliance/cargo-component/pull/271)

**Full Changelog**: bytecodealliance/cargo-component@v0.10.1...v0.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).

mergify bot referenced this pull request in andrzejressel/pulumi-gestalt


          chore(deps): update dependency cargo-component to 0.14.0 (#223)

4192fa5

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cargo-component](https://togithub.com/bytecodealliance/cargo-component) | minor | `0.13.0` -> `0.14.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/cargo-component (cargo-component)</summary>

### [`v0.14.0`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.14.0)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.2...v0.14.0)

#### What's Changed

-   Document additional `cargo-component` requirements by [@&#8203;yoshuawuyts](https://togithub.com/yoshuawuyts) in [https://github.com/bytecodealliance/cargo-component/pull/309](https://togithub.com/bytecodealliance/cargo-component/pull/309)
-   Update adapter builds by [@&#8203;alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/312](https://togithub.com/bytecodealliance/cargo-component/pull/312)
-   Rename `wasm32-wasi` to `wasm32-wasip1` by [@&#8203;alexcrichton](https://togithub.com/alexcrichton) in [https://github.com/bytecodealliance/cargo-component/pull/313](https://togithub.com/bytecodealliance/cargo-component/pull/313)
-   Update to -S cli instead of -S common for wasmtime commands by [@&#8203;iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/317](https://togithub.com/bytecodealliance/cargo-component/pull/317)
-   Respect build target from cargo config by [@&#8203;iawia002](https://togithub.com/iawia002) in [https://github.com/bytecodealliance/cargo-component/pull/319](https://togithub.com/bytecodealliance/cargo-component/pull/319)

#### New Contributors

-   [@&#8203;yoshuawuyts](https://togithub.com/yoshuawuyts) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/309](https://togithub.com/bytecodealliance/cargo-component/pull/309)
-   [@&#8203;iawia002](https://togithub.com/iawia002) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/317](https://togithub.com/bytecodealliance/cargo-component/pull/317)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.2...v0.14.0

### [`v0.13.2`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.2)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2)

#### What's Changed

-   Add `cargo component serve` subcommand by [@&#8203;primoly](https://togithub.com/primoly) in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)
-   added wasmtime wasi args for `cargo component serve` by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/308](https://togithub.com/bytecodealliance/cargo-component/pull/308)

#### New Contributors

-   [@&#8203;primoly](https://togithub.com/primoly) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/305](https://togithub.com/bytecodealliance/cargo-component/pull/305)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2

### [`v0.13.1`](https://togithub.com/bytecodealliance/cargo-component/releases/tag/v0.13.1)

[Compare Source](https://togithub.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1)

#### What's Changed

-   More `cargo component new` generator fixes by [@&#8203;calvinrp](https://togithub.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/304](https://togithub.com/bytecodealliance/cargo-component/pull/304)

**Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet