Various improvements to cargo-component.
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the following improvements to `cargo-component`: * `cargo-component` now componentizes based off the presence of component type information custom sections rather than always requiring a `[package.metadata.component]` section be present in `Cargo.toml`. * Bindings generation will now occur if a `wit` directory is present and `[package.metadata.component]` is not present in `Cargo.toml`. * Fix a panic in `cargo component add` if it encounters expected items that are not tables in `Cargo.toml`. * Fix not setting implicit tables for intermediate tables for the `cargo component add` command. * Fix not displaying anything when `--help` is present for commands passed directly to `cargo`. * `cargo-component` now uses the command adapter for binary examples and test/bench artifacts. * `cargo-component` now displays the same "Running" message that `cargo` does when using the `run`, `test`, and `bench` commands. * Some paths displayed in status messages have been prefix-stripped based on the CWD. This commit also contains a bit of refactoring to `run_cargo_command`, as it was getting long and unwieldy. Fixes bytecodealliance#236.
peterhuene
force-pushed
the
bug-fixes
branch
from
ed45674 to
f38df25
Compare
sunfishcode
reviewed
Feb 27, 2024
This makes using the section more ergonomic.
sunfishcode
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following improvements to
cargo-component:cargo-componentnow componentizes based off the presence of component type information custom sections rather than always requiring a[package.metadata.component]section be present inCargo.toml.witdirectory is present and[package.metadata.component]is not present inCargo.toml.cargo component addif it encounters expected items that are not tables inCargo.toml.cargo component addcommand.--helpis present for commands passed directly tocargo.cargo-componentnow uses the command adapter forbinexamples and test/bench artifacts.cargo-componentnow displays the same "Running" message thatcargodoes when using therun,test, andbenchcommands.This PR also contains a bit of refactoring to
run_cargo_command, as it was getting long and unwieldy.Fixes #236.