Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building aarch64-unknown-linux-gnu binary #232

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

nacardin
Copy link
Contributor

No description provided.

@nacardin nacardin marked this pull request as draft February 21, 2024 17:39
@sunfishcode
Copy link
Member

The PR looks straightforward. Could you comment on why you marked this as a draft?

@nacardin
Copy link
Contributor Author

The PR looks straightforward. Could you comment on why you marked this as a draft?

As is it, the openssl-sys dep has issues cross-compiling. I've been able to get to work on my fork with cargo-cross. I'll clean it up and update this PR soon. Thanks!

@nacardin nacardin marked this pull request as ready for review March 1, 2024 01:02
@nacardin
Copy link
Contributor Author

nacardin commented Mar 1, 2024

This is ready for review now. This worked on my fork https://github.com/nacardin/cargo-component/actions/runs/8105887458.

Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for tackling this!

@peterhuene peterhuene merged commit 549ee1b into bytecodealliance:main Mar 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants