Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋,
MkDocs 1.5.0 adds the
theme.custom_dir
property for ease of access and deprecates the previoustheme._vars
andconfig.user_configs
. I updated the script to handle both cases via a simple API check, the assumption currently is that thetheme.custom_dir
won't be going away so I felt this is a cleaner approach that comparing themkdocs.__version__
.Also tests will need to be adjusted, since they now rely on the source not changing... the themes change 1.5.0, which in turn will break every test case, because they rely on hashes... 😑I now see that hashes weren't such a good idea, I will try to handle it somehow in the coming days, since I take partial blame in the test design.
If this PR won't be merged before 1.5.0 then the world won't end, people will just have to live with the Deprecation warning for some time.