Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Brandyn,
I am using a FreeBSD-based Hadoop cluster for a project, and Hadoopy seems like an excellent way to manage Hadoop through Python. However, I discovered a few Cython compilation errors when I built the Hadoopy package on FreeBSD.
After an hour of debugging, I discovered the root cause of the problem. Your code calls the
fgetc(FILE *)
function, but passes avoid *
pointer instead of aFILE *
pointer. On most platforms this behaves as expected, but FreeBSD definesFILE
as a structure instead of a standard integer. The FreeBSDfgetc
implementation references members of this struct, which caused compilation errors.In this pull request I changed
void *
toFILE *
, which fixes the problem while maintaining compatibility with all platforms.Thanks!
Gregory