Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to enable FreeBSD support #56

Closed
wants to merge 1 commit into from
Closed

Conversation

gmazzola
Copy link

Hello Brandyn,

I am using a FreeBSD-based Hadoop cluster for a project, and Hadoopy seems like an excellent way to manage Hadoop through Python. However, I discovered a few Cython compilation errors when I built the Hadoopy package on FreeBSD.

After an hour of debugging, I discovered the root cause of the problem. Your code calls the fgetc(FILE *) function, but passes a void * pointer instead of a FILE * pointer. On most platforms this behaves as expected, but FreeBSD defines FILE as a structure instead of a standard integer. The FreeBSD fgetc implementation references members of this struct, which caused compilation errors.

In this pull request I changed void * to FILE *, which fixes the problem while maintaining compatibility with all platforms.

Thanks!

Gregory

@mshevelev
Copy link

I confirm that there is such a problem. I would also like to notice that in FreeBSD glibc doesn't support --version flag.

mshevelev pushed a commit to mshevelev/hadoopy that referenced this pull request Aug 29, 2012
@gmazzola gmazzola closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants