Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Flow 7+ compatibility #21

Merged
merged 4 commits into from
Apr 19, 2021
Merged

FEATURE: Flow 7+ compatibility #21

merged 4 commits into from
Apr 19, 2021

Conversation

andrehoffmann30
Copy link
Contributor

No description provided.

@bwaidelich
Copy link
Owner

@andrehoffmann30 thanks for this. Just to make sure. Did you test that this package actually works with Flow 7+?

@andrehoffmann30 andrehoffmann30 changed the title TASK: update compatible flow version in composer.json WIP: TASK: update compatible flow version in composer.json Apr 16, 2021
@andrehoffmann30
Copy link
Contributor Author

andrehoffmann30 commented Apr 16, 2021 •
edited
Loading

Hi @bwaidelich I am still working on it therefore I started a draft merge request. As so as everything is ready, I will change this to a normal merge request and write you, so that you can review the code. I added a WIP so that everyone can see directly that I am still working on this MR.

@andrehoffmann30 andrehoffmann30 marked this pull request as ready for review April 19, 2021 14:35
@andrehoffmann30 andrehoffmann30 changed the title WIP: TASK: update compatible flow version in composer.json TASK: update to be compatible with neos 7, refactor component to middleware Apr 19, 2021
@andrehoffmann30 andrehoffmann30 changed the title TASK: update to be compatible with neos 7, refactor component to middleware TASK: update to be compatible with neos/flow 7, refactor component to middleware Apr 19, 2021
@andrehoffmann30
Copy link
Contributor Author

Hi @bwaidelich, in my view this pr is ready to be reviewed. I test it in a project of a customer of my company and it seems to work as expected. Can you pleas review the code and test it? If you have any suggestions to improve the code or find any problems, please write me. Thank you.

@bwaidelich
Copy link
Owner

@andrehoffmann30 Wow, thanks a lot for your contribution.
Unfortunately I don't have the time to test this right now and I'm in vacation from tomorrow. But the code looks great and you even took the time to adjust the README <3

I'll go ahead, merge this into master and release a 6.0.0 – If we come across some bugs, we can always fix them in a patchlevel release.

Thanks again!

bwaidelich
bwaidelich approved these changes Apr 19, 2021
View reviewed changes
Copy link
Owner

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a cosmetic nitpick, but it looks great otherwise!

Classes/Http/Middleware/ProtectedResourceMiddleware.php Show resolved Hide resolved
@bwaidelich bwaidelich changed the title TASK: update to be compatible with neos/flow 7, refactor component to middleware FEATURE: Flow 7+ compatibility Apr 19, 2021
@bwaidelich bwaidelich merged commit e9a3474 into bwaidelich:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrehoffmann30 @bwaidelich