-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix position offset computing for window #920
Conversation
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 89.9% 89.93% +0.03%
==========================================
Files 57 57
Lines 1615 1620 +5
==========================================
+ Hits 1452 1457 +5
Misses 163 163
Continue to review full report at Codecov.
|
dae1528
to
2c55bdb
Compare
@bvaughn Tried to use puppeteer. There's a lot of boilerplate in installing and bootstrapping, but hope it can be resolved soon. |
Don't know how to fix it. Without sandboxing the error looks like this
|
I asked in local slack. Guys say all is good in travis. |
130c05e
to
b85448c
Compare
I'm gonna merge this and open PR with enabled e2e tests. Hope soon it will be merged :) |
Hey Bogdan. Thanks for running with this. 😄 I've been spending time offline the past few days because I had family visiting from the East coast for the holidays. Happy to see you moved forward without being blocked. |
Happy holidays! |
The case is visible when you scroll down 3000px, do small resize and scroll again. Viewport is cleaned. documentElement relativity is different.