Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set autoEscape to true on demo website #102

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

dorobila
Copy link
Contributor

The demo website was crashing when you typed [ into Search terms box.

Had a discussion with bvaughn about setting the autoEscape param to true on highlight-words-core package, but as he said, changing the default value is going to have performance implications for current users.

image
image

@sergei-startsev
Copy link
Collaborator

@dorobila autoEscape is not enabled by default, so I'd rather provide an option to enable/disable it on the demo to avoid confusion.

@dorobila
Copy link
Contributor Author

@sergei-startsev sure thing. I'll add the checkbox, but that is still going to break the app if it's unchecked on page load or unchecked and someone types [.

@sergei-startsev
Copy link
Collaborator

@dorobila I agree that this case should be handled out of the box, but changing the defaults can be considered a breaking change. There're some plans to refresh the library, so there will be an opportunity to change it in one of major releases.

@bvaughn bvaughn merged commit 7335d26 into bvaughn:master Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants