Demonstrate fix by updating to PR version of React #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not for merge. Updated package.json to point `react` and `react-dom` to PR that includes a bugfix: facebook/react#26317 Now when you run the tests, the second test no longer hangs.
bvaughn
reviewed
Mar 6, 2023
| "react": "^18.3.0-next-b72ed698f-20230303", | ||
| "react-dom": "^18.3.0-next-b72ed698f-20230303", | ||
| "react": "https://react-builds.vercel.app/api/prs/26317/packages/react", | ||
| "react-dom": "https://react-builds.vercel.app/api/prs/26317/packages/react-dom", |
There was a problem hiding this comment.
That's a neat trick. Doesn't seem to work with npm install though. Guess it's a Yarn specific thing?
Sure enough though, this version does fix the bug report I shared!
Going to play with it more now to see if it also fixes the original thing I was wrestling with!
There was a problem hiding this comment.
I think it works if you do yarn add react@https://react-builds.vercel.app/api/prs/26317/packages/react. If you do the URL by itself it gets confused.
There was a problem hiding this comment.
Yup! It works with Yarn. I was just using NPM by itself and noticed the install failed.
There was a problem hiding this comment.
I'll go ahead and publish an actual @experimental release once CI finishes, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for merge.
Updated package.json to point
reactandreact-domto PR that includes a bugfix: facebook/react#26317Now when you run the tests, the second test no longer hangs.