Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UTF-8 encoding and remove invalid characters from uids #19

Merged
merged 2 commits into from
Feb 22, 2017

Conversation

lasse-it
Copy link
Contributor

There is a problem, where that if a uid includes a slash, it fails with the error message "HTTPError: 404 Client Error: Not Found for url: https://owncloud/remote.php/dav/calendars/user/calendar/uid" this can be prevented by replacing all slashes, in the uids

@buzz
Copy link
Owner

buzz commented Feb 21, 2017

@mossroy I'm happy to see people still use this.
But what purpose does it serve as calendar subscriptions are supported by ownCloud/Nextcloud directly?

@mossroy
Copy link
Contributor

mossroy commented Feb 22, 2017

@buzz First, thanks a lot for this piece of software.

To sum up, it is really useful for me, as a workaround for nextcloud/server#1497
Calendar subscriptions on owncloud/nextcloud work well for the web client.
But these calendars are not available through the caldav protocol.
So, if your software/devices support direct subscription to webcal calendars (i.e. ical files downloaded through HTTP, considered read-only), you have to manually subscribe to them on each device.
And, it your software/device does not support it, you're stuck. It's the case for my smartphones, with the built-in calendar application of Firefox OS : it only supports caldav protocol.

Exposing all the calendars through caldav ensures your caldav clients always have all your calendars (including subscriptions), even if you add/remove some of them.

NB : I only contributed half of this pull-request, @lasse-it contributed the slashes workaround (which I could not test because I don't have this issue)

buzz
buzz previously approved these changes Feb 22, 2017
@buzz buzz dismissed their stale review February 22, 2017 16:06

made a mistake

@buzz
Copy link
Owner

buzz commented Feb 22, 2017

Interesting. That makes sense I guess. I solve this by using some app called ICS subscription or similar on Android.

I would merge

  • UTF-8 encoding for downloaded ICS files ef4210d
  • Replace slashes in uids with valid url charecters 00a2741

But could you remove 662e356 from the PR as it seems to be specific to the lasse-it fork?

@mossroy
Copy link
Contributor

mossroy commented Feb 22, 2017

I agree with you to remove 662e356 from the PR. Unfortunately, I did not submit it myself : I suppose @lasse-it needs to do that

@buzz
Copy link
Owner

buzz commented Feb 22, 2017

Alright. Either this or I'm going to manually merge the two first commits (later)…

@lasse-it
Copy link
Contributor Author

Okay, I'll try to remove the README @buzz

@lasse-it lasse-it force-pushed the master branch 2 times, most recently from 662e356 to 00a2741 Compare February 22, 2017 18:13
@lasse-it
Copy link
Contributor Author

Should be fixed now

@buzz buzz merged commit e3818f1 into buzz:master Feb 22, 2017
buzz added a commit that referenced this pull request Aug 11, 2018
Set UTF-8 encoding and remove invalid characters from uids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants