Fix menu bar update frequency #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +12,9 @@ export function setupActions(store) { | |||
| // Clear update notice | |||
| store.dispatch(updateInstalled()); | |||
|
|
|||
| // Update the menu | |||
| store.subscribe(debounce(() => setupMenu(store), 500)); | |||
There was a problem hiding this comment.
Why debounce menu creation? Isn't 500ms maybe a bit much?
There was a problem hiding this comment.
Its not menu creation. Everytime the store updates (any action regardless of it having anything to do with menu or not) this re-draws the menu which is slightly heavy process. And sometimes this function (subcribed function) gets called 20 times in 100ms. So just wanted to avoid performance issues and lags
perry-mitchell
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373