Fix undefined config preference during migration #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
Layerr: Failed executing config migration: startInBackground: Cannot read properties of undefined (reading 'startInBackground')
error at startup for v2.24.x.New to Buttercup here. The Buttercup app closed itself immediately at start, right after a clean (first) install. The error below showed up if I opened the app in a terminal.
I can confirm this happens in v2.24.x (<= v2.24.3) but not v2.23.1. The cause is that "startInBackground" config migration occurs before storage content is put, but no config is available then (for the first use). This would not happen if you opened the app before, and that you have a config created.