Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 2.23.0, saving preferences always close and reopen main window (not only on language modification) #1269

Closed
Oxalin opened this issue Dec 20, 2023 · 2 comments · Fixed by #1318

Comments

@Oxalin
Copy link
Contributor

Oxalin commented Dec 20, 2023

Reproduced under Windows with v2.24.4

7ccab93 introduced closeAndReopenMainWindow(). This should be triggered only on language modifcation so the new language is applied to the interface.

However, as of version 2.23.0, any save of preferences calls closeAndReopenMainWindow(). onLanguageChanged() is probably being triggered for wrong events.

@perry-mitchell
Copy link
Member

It's not a bug, and was required when originally implemented. Due to more recent features it's no longer required and could be removed.

@quintushr
Copy link
Contributor

quintushr commented Feb 5, 2024

After reviewing the code, it seems that triggering the event on every configuration save might need some optimization. Instead of calling the onLanguageChanged() event with every preference save, could we consider triggering it only when there are actual language modifications? This might address the issue raised by @Oxalin while still maintaining the necessary functionality. What are your thoughts on this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants