Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ask for passphrase every once in a while when biometric unlock is active #1201

Closed
macno opened this issue Apr 14, 2023 · 3 comments · Fixed by #1231
Closed

ask for passphrase every once in a while when biometric unlock is active #1201

macno opened this issue Apr 14, 2023 · 3 comments · Fixed by #1231
Labels
Effort: Medium Priority: Low Status: Completed

Comments

@macno
Copy link
Contributor

macno commented Apr 14, 2023

I'd love to be forced to input the passphrase every X days to unlock the vault even if I enabled the biometric unlock.
@perry-mitchell
Copy link
Member

I like this idea.

@macno
Copy link
Contributor Author

macno commented Jul 30, 2023 •
edited
Loading

Hi @perry-mitchell since I have some free time in the next weeks I'd like to start implementing it. Could you provide me any pointers to where to look at?

I think it should be around https://github.com/buttercup/buttercup-desktop/blob/master/source/renderer/components/PasswordPrompt.tsx#L42

@macno
Copy link
Contributor Author

macno commented Jul 30, 2023

This is the plan:

  • add two new settings (global? per vault?):

    • forcePromptPasswordAfterBioUnlockCount
    • forcePromptPasswordAfterDeltaTime

    whichever comes first, user will have to unlock the vault typing the password.
    A value of 0 will disable the check

  • store 2 values after each bio unlock (per vault)

    • bioUnlockCount
    • bioUlockTimestamp

WDYT?

macno added a commit to macno/buttercup-desktop that referenced this issue Aug 2, 2023
@macno
PasswordPrompt: check if password prompt is required before biometric…
4bed731 
… unlock

implements buttercup#1201
@macno macno mentioned this issue Aug 2, 2023
Merged
perry-mitchell pushed a commit that referenced this issue Nov 15, 2023
@macno
Feat/force password prompt (#1231)
3419634 
* Add new properties to VaultSettingsLocal

* VaultSettingsDialog: add new Biometric settings

* PasswordPrompt: check if password prompt is required before biometric unlock

implements #1201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort: Medium Priority: Low Status: Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/force password prompt macno/buttercup-desktop
2 participants
@macno @perry-mitchell