Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor jQuery usages to element selectors #186

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

srsgores
Copy link
Contributor

Octane apps consuming this addon will throw the following error:

2vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:15812 Uncaught TypeError: (0 , a.jQuery) is not a function
at c.s.JQUERY_INTEGRATION.l.$ (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:15812)
at c.didRender (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:61007)
at c.trigger (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:16196)
at c.r [as trigger] (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:15197)
at n.i.didCreate (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:5676)
at e.t.commit (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:23477)
at e.r.commit (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:23575)
at Be (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:23681)
at r.i._renderRoots (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:8235)
at r.i._renderRootsTransaction (vendor-e1f3e6c162fd0a87c91ac02da93f94a2.js:formatted:8257)

This PR removes the deprecated jQuery selectors in favour of "native", classic Ember selectors using this.element.

Later on, I plan on submitting another MR which migrates this addon to octane.

Copy link
Collaborator

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lukemelia lukemelia merged commit 9eea2a5 into bustle:master Nov 18, 2020
@lukemelia
Copy link
Collaborator

Thanks @srsgores!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants