Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning in Ember 3.5 #160

Closed
patrickberkeley opened this issue Nov 5, 2018 · 1 comment · Fixed by #163
Closed

Deprecation warning in Ember 3.5 #160

patrickberkeley opened this issue Nov 5, 2018 · 1 comment · Fixed by #163

Comments

@patrickberkeley
Copy link

In Ember 3.5.1 we are seeing a warning:

deprecate.js:102 DEPRECATION: You called <bnb@component:mobiledoc-editor::ember5870>.sendAction("did-create-editor") but Component#sendAction is deprecated. Please use closure actions instead. [deprecation id: ember-component.send-action] See https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action for more details.

Is this a known issue?
backspace added a commit to backspace/ember-mobiledoc-editor that referenced this issue Nov 7, 2018
@backspace
Move away from deprecated sendAction function
76ccebc 
This closes bustle#160. I followed the deprecation guidelines here:
https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_ember-component-send-action

However, there are various ways this could be accomplished,
so I’ll be asking for feedback in my PR.
This was referenced Nov 7, 2018
Open
Merged
@backspace
Copy link
Contributor

It’s an issue in a lot of addons but won’t be a real problem until Ember 4.0, according to the documentation. However, I’ve submitted a PR to fix it regardless; it may need some guidance from the maintainers but it’s a start!

whatthewhat pushed a commit to visiblevc/ember-mobiledoc-editor that referenced this issue May 6, 2019
@backspace @whatthewhat
Move away from deprecated sendAction function
8dc2431 
This closes bustle#160. I followed the deprecation guidelines here:
https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_ember-component-send-action

However, there are various ways this could be accomplished,
so I’ll be asking for feedback in my PR.
backspace added a commit to backspace/ember-mobiledoc-editor that referenced this issue Jun 9, 2020
@backspace
Move away from deprecated sendAction function
44ae731 
This closes bustle#160.
backspace added a commit to backspace/ember-mobiledoc-editor that referenced this issue Jun 9, 2020
@backspace
Move away from deprecated sendAction function
96fe380 
This closes bustle#160.
backspace added a commit to backspace/ember-mobiledoc-editor that referenced this issue Jun 9, 2020
@backspace
Move away from deprecated sendAction function
42cfe9b 
This closes bustle#160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move away from deprecated sendAction function backspace/ember-mobiledoc-editor
2 participants
@patrickberkeley @backspace