Skip to content

Commit

Permalink
CRAN Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
DavisVaughan committed May 10, 2019
1 parent 10de756 commit e178400
Showing 1 changed file with 8 additions and 17 deletions.
25 changes: 8 additions & 17 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,17 @@
## Resubmission

- I have written 'Tiingo' in single quotes in the Description title and description.
- I have added a URL for the Tiingo API in the Description
- Based on discussion with Swetlana and Uwe, I have not changed \dontrun{}
to \donttest{}. See below:
## Release Summary

"Thanks! Everything wrapped in \dontrun{} requires API authentication (a
token set as an environment variable). I heard that if I wrap them in
\donttest{}, CRAN will run them later anyways? They will fail if that is
the case. *Should I still do so?*"
This is the second release of riingo. It:
- Uses `glue::glue_collapse()` rather than `glue::collapse()` to avoid a warning.
- Updates JSON parsing to accomodate a change in the Tiingo API
- Adds handling of partial successes when downloading multiple tickers.

## Release Summary
This is the first release of riingo. riingo provides an R interface to the
Tiingo API for stock prices and cryptocurrency data.
The maintainer changed because I updated my email.

## Test environments
* local OS X install, R 3.4.3
* ubuntu 14.04 (on travis-ci), R 3.4.3
* local OS X install, R 3.5.3
* ubuntu 14.04 (on travis-ci) (devel and release)
* win-builder (devel and release)

## R CMD check results

0 errors | 0 warnings | 0 notes

* This is a new release.

0 comments on commit e178400

Please sign in to comment.