-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add context-menu items to tree view and tabs #213
Conversation
Cant say I agree with implementation design, but its better than nothing |
Ya that is one reason it is still a draft. I was trying to avoid this being a breaking but because of the way we get cwd it might have to be. |
The only other way I could think of doing this would be to have separate commands for the tree-view and tab-bar context menu but I didn't want to create a whole bunch of |
Terminus does this fairly well, maybe thats a starting point. In all honesty, I cant see any such addition being a non breaking change your right and we agree on this much =) |
It doesn't look like terminus does anything with the items selected in tree-view. |
But it maps to folder just fine optionally which is the point and does via treeview Actually I posted a gif of it doing it... let me see if I can find it on here Here #38 (comment) xterminal vs terminus |
The "map terminals" feature is different than just changing cwd based on context-menu element. For one the map terminals feature does not work when you want to have multiple terminals open or when you want a terminal to open to a specific folder and keep that terminal open even when changing files in Atom. |
8cb5684
to
088e606
Compare
BREAKING CHANGE: change the way cwd is calculated
088e606
to
31be163
Compare
🎉 This PR is included in version 12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@UziTech Sorry but it doesn't open the selected folder in the terminal for me. Don't see, what i am doing wrong. |
Adds context menu items to tree-view and tab-bar. When executing from tree-view or tab bar opens terminal in folder of selected item.
This will be a breaking change with the way we determine cwd.
fixes #212
fixes #96