Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry initialization #133

Closed
wants to merge 1 commit into from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jul 30, 2020

A simple fix for #57. Whenever this error happens, I try again and it works the second time. So I think it is better to implement the retry in the code!

Fixes #57

@aminya aminya force-pushed the retryInitialization branch from ccc3815 to 0db9682 Compare July 30, 2020 01:10
@UziTech
Copy link
Member

UziTech commented Jul 30, 2020

It is this line that is failing according to the stack traces in #57:

this.fitAddon.fit()

we could just add a try catch and fail silently but it would be better to figure out why it is failing.

@UziTech
Copy link
Member

UziTech commented Aug 3, 2020

#136 might fix #57 it prevents .fit() from being called when the terminal width or height is 0

@aminya
Copy link
Contributor Author

aminya commented Aug 3, 2020

I will try that!

@aminya
Copy link
Contributor Author

aminya commented Aug 5, 2020

I will close this in favor of #136

@aminya aminya closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught Error: This API only accepts integers
2 participants