fix: resolve initialization promise after terminal is visible

bus-stop · Aug 5, 2020 · 2589573 · 2589573
1 parent 050931e
commit 2589573
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/element.js b/src/element.js
@@ -105,8 +105,13 @@ class XTerminalElementImpl extends HTMLElement {
 				const lastEntry = entries.pop()
 				if (lastEntry.intersectionRatio === 1.0) {
 					this.terminalDivInitiallyVisible = true
-					await this.createTerminal()
-					this.applyPendingTerminalProfileOptions()
+					try {
+						await this.createTerminal()
+						this.applyPendingTerminalProfileOptions()
+						resolveInit()
+					} catch (ex) {
+						rejectInit(ex)
+					}
 					// Remove observer once visible
 					this.terminalDivIntersectionObserver.disconnect()
 					this.terminalDivIntersectionObserver = null
@@ -141,7 +146,6 @@ class XTerminalElementImpl extends HTMLElement {
 				},
 				{ capture: true },
 			)
-			resolveInit()
 		} catch (ex) {
 			rejectInit(ex)
 			throw ex