Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -DPYTHON_EXECUTABLE to cmake #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

minoki
Copy link

@minoki minoki commented Mar 2, 2023

When building ndi-python with virtualenv without activating it, cmake tries to find system-installed python:

$ # No myenv/bin/activate!
$ myenv/bin/python setup.py build
...
-- Found PythonInterp: <some system-installed python>
-- Found PythonLibs: <some system-installed python>
...

This is not good because the version of found one might be different than virtualenv's one.

Therefore, cmake's PYTHON_EXECUTABLE variable should be explicitly set by setup.py.

This is important when using a virtualenv without activating it.
minamikik added a commit to minamikik/ndi-python that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant