Data race in cluster setup using Olric v0.5.5

[zhp007]

In the olric_test.go, add the following sample test:

func TestOlricCluster(t *testing.T) {
	cluster := newTestOlricCluster(t)
	cluster.addMember(t)
	cluster.addMember(t)
	cluster.addMember(t)
	cluster.addMember(t)
	cluster.addMember(t)
	require.Len(t, cluster.members, 5)
}

Then run the command:

for i in {1..10}; do go test -count=1 -race -run 'TestOlricCluster' ; done

Some rounds will fail with the following error message:

WARNING: DATA RACE
Write at 0x00c0001f0348 by goroutine 253:
  github.com/buraksezer/olric/internal/cluster/routingtable.(*RoutingTable).Start()
      /Users/zhengrenpan/open-source/olric/internal/cluster/routingtable/routingtable.go:370 +0x3d0
  github.com/buraksezer/olric.(*Olric).Start()
      /Users/zhengrenpan/open-source/olric/olric.go:345 +0x32c
  github.com/buraksezer/olric.newTestOlricWithConfig.func2()
      /Users/zhengrenpan/open-source/olric/olric_test.go:61 +0x2c

Previous read at 0x00c0001f0348 by goroutine 278:
  github.com/buraksezer/olric/internal/cluster/routingtable.(*RoutingTable).setOwnedPartitionCount()
      /Users/zhengrenpan/open-source/olric/internal/cluster/routingtable/routingtable.go:159 +0xcc
  github.com/buraksezer/olric/internal/cluster/routingtable.(*RoutingTable).updateRoutingCommandHandler()
      /Users/zhengrenpan/open-source/olric/internal/cluster/routingtable/operations.go:107 +0x608
  github.com/buraksezer/olric/internal/cluster/routingtable.(*RoutingTable).updateRoutingCommandHandler-fm()
      <autogenerated>:1 +0x90
  github.com/buraksezer/olric/internal/server.Handler.ServeRESP()
      /Users/zhengrenpan/open-source/olric/internal/server/handler.go:57 +0x3ec
  github.com/buraksezer/olric/internal/server.(*Handler).ServeRESP()
      <autogenerated>:1 +0xa4
  github.com/buraksezer/olric/internal/server.(*ServeMux).ServeRESP()
      /Users/zhengrenpan/open-source/olric/internal/server/mux.go:73 +0x3ec
  github.com/buraksezer/olric/internal/server.(*ServeMux).ServeRESP-fm()
      <autogenerated>:1 +0x90
  github.com/tidwall/redcon.handle.func2()
      /Users/zhengrenpan/go/pkg/mod/github.com/tidwall/[email protected]/redcon.go:437 +0x2b8
  github.com/tidwall/redcon.handle()
      /Users/zhengrenpan/go/pkg/mod/github.com/tidwall/[email protected]/redcon.go:450 +0x9c
  github.com/tidwall/redcon.serve.func2()
      /Users/zhengrenpan/go/pkg/mod/github.com/tidwall/[email protected]/redcon.go:386 +0x40

Goroutine 253 (running) created at:
  github.com/buraksezer/olric.newTestOlricWithConfig()
      /Users/zhengrenpan/open-source/olric/olric_test.go:60 +0x2d4
  github.com/buraksezer/olric.(*testOlricCluster).addMemberWithConfig()
      /Users/zhengrenpan/open-source/olric/olric_test.go:108 +0x298
  github.com/buraksezer/olric.(*testOlricCluster).addMember()
      /Users/zhengrenpan/open-source/olric/olric_test.go:115 +0x78
  github.com/buraksezer/olric.TestOlricCluster()
      /Users/zhengrenpan/open-source/olric/olric_test.go:146 +0x68
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.21.6/libexec/src/testing/testing.go:1595 +0x1b0
  testing.(*T).Run.func1()
      /opt/homebrew/Cellar/go/1.21.6/libexec/src/testing/testing.go:1648 +0x40

Goroutine 278 (running) created at:
  github.com/tidwall/redcon.serve()
      /Users/zhengrenpan/go/pkg/mod/github.com/tidwall/[email protected]/redcon.go:386 +0x688
  github.com/tidwall/redcon.(*Server).Serve()
      /Users/zhengrenpan/go/pkg/mod/github.com/tidwall/[email protected]/redcon.go:317 +0x158
  github.com/buraksezer/olric/internal/server.(*Server).ListenAndServe()
      /Users/zhengrenpan/open-source/olric/internal/server/server.go:189 +0x598
  github.com/buraksezer/olric.(*Olric).Start.func1()
      /Users/zhengrenpan/open-source/olric/olric.go:324 +0x40
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /Users/zhengrenpan/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x7c

[buraksezer]

Hey @zhp007,

Thank you for reporting this. The problem has been fixed, and Olric v0.5.6 has been released. https://github.com/buraksezer/olric/releases/tag/v0.5.6

The current solution fixes the problem, but we need more complicated refactoring to improve the code quality. This can be done in v0.6.0.