every 10 days of the year starting on the 65th day of the year

[gautaz]

Hello,

Looking at the laterjs text parser, I was wondering why the rank regex was limited to 59.
In fact, it makes sense for all time units but for days in the year.
Is there any particular reason for this ?

[bunkat]

Nope, that is definitely an oversight. You're right that it should go up to 366 to cover all cases.

[gautaz]

OK, actually there is a way to work around the issue with:
every 10 days of the year starting on the 0300 day of the year

[gautaz]

Or to get back to the original example:
every 10 days of the year starting on the 0065 day of the year
But it seems a bit awkward...

[gautaz]

Fixing this with a regex that checks english grammar seems overwhelming, perhaps:

/^((\d+)(st|nd|rd|th)?)\b/

would be enough for checking a rank?
If the user is not using the right cardinality suffix, I guess laterjs will still work as expected?

[bunkat]

Yes, this should work just fine. Laterjs just strips the suffix anyways so it isn't important that it is correct and I wasn't doing all of the checks that would have been required to make sure that the value provided was actually valid anyways.

[gautaz]

Sorry for the delay,
@bunkat Do you want me to do a PR for this?

[bunkat]

If you want to, that would be great. Thanks!

[gautaz]

Done :-). There is only one additional test case (two in fact for the day of year restriction), perhaps a few more would help...