Also check out-of-bounds on player inventory

bundabrg · Mar 8, 2021 · d80372e · d80372e
1 parent ffae694
commit d80372e
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/connector/src/main/java/org/geysermc/connector/inventory/PlayerInventory.java b/connector/src/main/java/org/geysermc/connector/inventory/PlayerInventory.java
@@ -28,6 +28,7 @@
 import lombok.Getter;
 import lombok.NonNull;
 import lombok.Setter;
+import org.geysermc.connector.GeyserConnector;
 import org.geysermc.connector.network.session.GeyserSession;
 
 public class PlayerInventory extends Inventory {
@@ -55,10 +56,18 @@ public void setCursor(@NonNull GeyserItemStack newCursor, GeyserSession session)
     }
 
     public GeyserItemStack getItemInHand() {
+        if (36 + heldItemSlot > this.size) {
+            GeyserConnector.getInstance().getLogger().debug("Held item slot was larger than expected!");
+            return GeyserItemStack.EMPTY;
+        }
         return items[36 + heldItemSlot];
     }
 
     public void setItemInHand(@NonNull GeyserItemStack item) {
+        if (36 + heldItemSlot > this.size) {
+            GeyserConnector.getInstance().getLogger().debug("Held item slot was larger than expected!");
+            return;
+        }
         items[36 + heldItemSlot] = item;
     }