Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM audit found vulnerability in @oclif/plugin-warn-if-update-available #583

Closed
jloleysens opened this issue Nov 1, 2024 · 0 comments · Fixed by #584
Closed

NPM audit found vulnerability in @oclif/plugin-warn-if-update-available #583

jloleysens opened this issue Nov 1, 2024 · 0 comments · Fixed by #584

Comments

@jloleysens
Copy link

Hello 👋🏻 , we would like to use bump CLI in Kibana (PR) but npm audit raised the following high severity vulnerability:

❯ npm audit
# npm audit report

lodash.template  *
Severity: high
Command Injection in lodash - https://github.com/advisories/GHSA-35jh-r3h4-6jhm
fix available via `npm audit fix`
node_modules/lodash.template
  @oclif/plugin-warn-if-update-available  1.7.0 || 2.0.0 || 2.1.0 - 3.0.16
  Depends on vulnerable versions of lodash.template
  node_modules/@oclif/plugin-warn-if-update-available

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix

Would it be possible to upgrade to a version of @oclif/plugin-warn-if-update-available that does not have a vulnerable dependency? This is kind of a blocker for our PR to Kibana.
@jloleysens jloleysens mentioned this issue Nov 1, 2024
Merged
@paulRbr paulRbr mentioned this issue Nov 1, 2024
Merged
paulRbr added a commit to paulRbr/cli that referenced this issue Nov 4, 2024
@paulRbr
deps: temporarily remove 'warn-if-update-available' package
5e20681 
We remove this oclif plugin for now as it's not compatible with the
old version of oclif we are using.

This should be temporary until we have finished to upgrade oclif (bump-sh#448)

about bump-sh#583
@paulRbr paulRbr mentioned this issue Nov 4, 2024
Merged
jloleysens added a commit to elastic/kibana that referenced this issue Nov 14, 2024
@jloleysens @kibanamachine
[OAS] Publish OAS bundles to bump.sh (#197482)
8278b06 
## Summary

Publish OAS docs to bump.sh on merge to `main` or `8.x`

## To reviewers
* For now actual publication requires a manual step on bump.sh (so
things aren't going live immediately)
* Will get to serverless OAS docs next!

## Blockers

* Address vulnerable deps before merging:
bump-sh/cli#583

---------

Co-authored-by: kibanamachine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this issue Nov 14, 2024
@jloleysens
[OAS] Publish OAS bundles to bump.sh (elastic#197482)
bfd42e0 
## Summary

Publish OAS docs to bump.sh on merge to `main` or `8.x`

## To reviewers
* For now actual publication requires a manual step on bump.sh (so
things aren't going live immediately)
* Will get to serverless OAS docs next!

## Blockers

* Address vulnerable deps before merging:
bump-sh/cli#583

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 8278b06)

# Conflicts:
#	oas_docs/makefile
#	oas_docs/output/kibana.serverless.yaml
#	oas_docs/output/kibana.yaml
jloleysens added a commit to jloleysens/kibana that referenced this issue Nov 14, 2024
@jloleysens
[OAS] Publish OAS bundles to bump.sh (elastic#197482)
f31be90 
## Summary

Publish OAS docs to bump.sh on merge to `main` or `8.x`

## To reviewers
* For now actual publication requires a manual step on bump.sh (so
things aren't going live immediately)
* Will get to serverless OAS docs next!

## Blockers

* Address vulnerable deps before merging:
bump-sh/cli#583

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 8278b06)

# Conflicts:
#	oas_docs/makefile
#	oas_docs/output/kibana.serverless.yaml
#	oas_docs/output/kibana.yaml
lcawl pushed a commit to jloleysens/kibana that referenced this issue Nov 15, 2024
@jloleysens @lcawl
[OAS] Publish OAS bundles to bump.sh (elastic#197482)
c7e9edd 
## Summary

Publish OAS docs to bump.sh on merge to `main` or `8.x`

## To reviewers
* For now actual publication requires a manual step on bump.sh (so
things aren't going live immediately)
* Will get to serverless OAS docs next!

## Blockers

* Address vulnerable deps before merging:
bump-sh/cli#583

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 8278b06)

# Conflicts:
#	oas_docs/makefile
#	oas_docs/output/kibana.serverless.yaml
#	oas_docs/output/kibana.yaml
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@jloleysens @kibanamachine @CAWilson94
[OAS] Publish OAS bundles to bump.sh (elastic#197482)
9c299d3 
## Summary

Publish OAS docs to bump.sh on merge to `main` or `8.x`

## To reviewers
* For now actual publication requires a manual step on bump.sh (so
things aren't going live immediately)
* Will get to serverless OAS docs next!

## Blockers

* Address vulnerable deps before merging:
bump-sh/cli#583

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@jloleysens @kibanamachine @CAWilson94
[OAS] Publish OAS bundles to bump.sh (elastic#197482)
cea782c 
## Summary

Publish OAS docs to bump.sh on merge to `main` or `8.x`

## To reviewers
* For now actual publication requires a manual step on bump.sh (so
things aren't going live immediately)
* Will get to serverless OAS docs next!

## Blockers

* Address vulnerable deps before merging:
bump-sh/cli#583

---------

Co-authored-by: kibanamachine <[email protected]>
jloleysens added a commit to elastic/kibana that referenced this issue Nov 27, 2024
@jloleysens @kibanamachine
@elasticmachine @lcawl
[8.16] [OAS] Publish OAS bundles to bump.sh (#197482) (#200136)
b3d1d7a 
# Backport

This will backport the following commits from `main` to `8.16`:
- [[OAS] Publish OAS bundles to bump.sh
(#197482)](#197482)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T08:15:47Z","message":"[OAS]
Publish OAS bundles to bump.sh (#197482)\n\n## Summary\r\n\r\nPublish
OAS docs to bump.sh on merge to `main` or `8.x`\r\n\r\n## To
reviewers\r\n* For now actual publication requires a manual step on
bump.sh (so\r\nthings aren't going live immediately)\r\n* Will get to
serverless OAS docs next!\r\n\r\n## Blockers\r\n\r\n* Address vulnerable
deps before
merging:\r\nhttps://github.com/bump-sh/cli/issues/583\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"8278b0650ad4bb35e1a702889afad1f96eae2cd6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:OAS","v8.16.0","backport:version","v8.17.0"],"number":197482,"url":"https://github.com/elastic/kibana/pull/197482","mergeCommit":{"message":"[OAS]
Publish OAS bundles to bump.sh (#197482)\n\n## Summary\r\n\r\nPublish
OAS docs to bump.sh on merge to `main` or `8.x`\r\n\r\n## To
reviewers\r\n* For now actual publication requires a manual step on
bump.sh (so\r\nthings aren't going live immediately)\r\n* Will get to
serverless OAS docs next!\r\n\r\n## Blockers\r\n\r\n* Address vulnerable
deps before
merging:\r\nhttps://github.com/bump-sh/cli/issues/583\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"8278b0650ad4bb35e1a702889afad1f96eae2cd6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197482","number":197482,"mergeCommit":{"message":"[OAS]
Publish OAS bundles to bump.sh (#197482)\n\n## Summary\r\n\r\nPublish
OAS docs to bump.sh on merge to `main` or `8.x`\r\n\r\n## To
reviewers\r\n* For now actual publication requires a manual step on
bump.sh (so\r\nthings aren't going live immediately)\r\n* Will get to
serverless OAS docs next!\r\n\r\n## Blockers\r\n\r\n* Address vulnerable
deps before
merging:\r\nhttps://github.com/bump-sh/cli/issues/583\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"8278b0650ad4bb35e1a702889afad1f96eae2cd6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: upgrade dependencies to avoid npm audit errors paulRbr/cli
1 participant
@jloleysens