Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table-clear-button): convert emitOnly BooleanInput to Input #1604

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

kflo411
Copy link
Collaborator

@kflo411 kflo411 commented Sep 17, 2024

Description

@BooleanInput (a NovoElements utility) was not working as expected in the data-table-clear-button. Switched back to @Input().

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

Copy link
Contributor

github-actions bot commented Sep 17, 2024

Visit the preview URL for this PR (updated for commit 74ab25b):

https://novo-elements--pr1604-fix-emitonly-9lkhoguu.web.app

(expires Wed, 02 Oct 2024 19:49:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants