Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NovoDataTable): making pagination marker background color dynamic #1290

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Apr 11, 2022

Description

This resolves issue #1267 by making the background of the data table pagination marker dynamic. instead of a hardcoded color, it's now simply black with an opacity of 10%, so it will render as whatever color the header is, just slightly darker.

pagination background

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@bvkimball
Copy link
Contributor

I think this is just a Quick fix. On darker backgrounds it probably should inverse, and font-text should update.

@dvoegelin dvoegelin merged commit a39bf0d into master Apr 12, 2022
@dvoegelin dvoegelin deleted the f/dynamicPageBackground branch April 12, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants