-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy bom for platform/0.9 #288
Conversation
Per discussion in 2/17 Working Group, instead of totally discarding legacy boms, we may want to save them to a file such as |
From yesterday's core sync, @samj1912 to provide suggestions for the "compat" format given that we have requirements around media types. |
@natalieparellano sorry for not voting on this, but based on the recent discussions are we deciding to add the "compat" part to the spec? It looks like we did in the slack conversations as well. Are there supposed to be changes to this PR? |
@samj1912 will leave a media type suggestion to this PR. |
We should do the following - put the legacy bom in JSON format in (the same format we put it in the label) with the extension We can document that if users wish to upload it as an attestation or attachment the media type can be |
Please see 9089048 |
Do we need to document the media type as well in the buildpack API? https://github.com/buildpacks/spec/blob/main/buildpack.md#software-bill-of-materials |
Legacy boms output by older buildpacks will be ignored by the platform. Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano I see that the legacy boms were added underneath individual buildpacks. I was hoping we could just output the combined one at the top level and save lifecycle some effort. It already has the combination logic and puts it in a label. We could just output the same JSON blob in a file at the top level? |
This change proposes that legacy boms output by older buildpacks be ignored on the newest platform.
The lifecycle implementation could output a warning if any boms are ignored.