Buildpack support for sBOM #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <[email protected]>
sclevine
approved these changes
Nov 5, 2021
nebhale
approved these changes
Nov 5, 2021
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
commented
Nov 9, 2021
jromero
reviewed
Nov 9, 2021
Co-authored-by: Javier Romero <[email protected]>
Co-authored-by: Javier Romero <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
sambhav
reviewed
Nov 10, 2021
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
sambhav
reviewed
Nov 10, 2021
sambhav
reviewed
Nov 10, 2021
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
requested review from
jromero,
sambhav,
nebhale and
sclevine
jromero
approved these changes
Nov 10, 2021
Signed-off-by: Natalie Arellano <[email protected]>
sambhav
approved these changes
Nov 10, 2021
| 1. Write a partial Bill-of-Material to `<layers>/build.toml` describing any provided build dependencies. | ||
| 1. Write a partial Software Bill of Materials to `<layers>/<layer>.sbom.<ext>` describing any dependencies provided in the layer. | ||
| 1. Write a partial Software Bill of Materials to `<layers>/launch.sbom.<ext>` describing any provided application dependencies not associated with a layer. | ||
| 1. Write a partial Software Bill of Materials to `<layers>/build.sbom.<ext>` describing any provided build dependencies not associated with a layer. |
There was a problem hiding this comment.
I think one thing that I know people have gotten confused about, is where they should write sbom for libraries that were included in an output compiled binary. For eg go libraries in a go binary. Those should technically be in the launch sbom as they are present in the final app image. On the other hand tools like a package manager might be better off in the build sbom. Not sure if we should clarify here or in the docs.
Signed-off-by: Natalie Arellano <[email protected]> Co-authored-by: Sambhav Kothari <[email protected]>
sclevine
approved these changes
Nov 17, 2021
nebhale
approved these changes
Nov 18, 2021
jkutner
approved these changes
Nov 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Natalie Arellano [email protected]