Bundle lifecycle with samples builder #151
Conversation
buildpacks/java-maven/bin/build
Outdated
| export JAVA_HOME=${jdk_layer_dir} | ||
| mkdir -p ${jdk_layer_dir}/exec.d | ||
| cat > "${jdk_layer_dir}/exec.d/jdk.sh" << EOF | ||
| echo JAVA_HOME=${jdk_layer_dir} |
There was a problem hiding this comment.
Why has this been changed to echo?
There was a problem hiding this comment.
Because the spec states that env vars should be output as key-value pairs -- https://github.com/buildpacks/spec/blob/main/buildpack.md#execd and https://github.com/buildpacks/spec/blob/main/buildpack.md#execd-output-toml. What was missing is a redirection to "FD 3".
There was a problem hiding this comment.
I still don't see the redirection to fd3?
There was a problem hiding this comment.
It's in 5b94deb . I think this is GH being slow to update.
AidanDelaney
force-pushed
the
bundle-lifecycle
branch
from
b8d316b to
5b94deb
Compare
|
The CircleCI workflow uses the last released builder. This means that it does not run the workflow using changes in the PR'ed builder. I'm not sure of the value of this workflow. |
Use the latest lifecycle and bundle it with the builder Signed-off-by: Aidan Delaney <[email protected]>
Convert from profile.d to exec.d Signed-off-by: Aidan Delaney <[email protected]>
Show the value of JAVA_HOME for debugging purposes Signed-off-by: Aidan Delaney <[email protected]>
Release a new version of the java-maven buildpack to force any consumers of our builder to pull the latest buildpack. Signed-off-by: Aidan Delaney <[email protected]>
AidanDelaney
force-pushed
the
bundle-lifecycle
branch
from
d4b938b to
fed3532
Compare
|
We made most of these changes in #140. Making the profile.d -> exec.d changes in a separate PR. |
Use the latest lifecycle and bundle it with the builder