WIP: Trigger build workflow on lifecycle-release dispatch event and update builder.toml lifecycle version #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures sample builders are up-to-date with the lifecycle. See buildpacks/lifecycle#801 Signed-off-by: glokta1 <[email protected]>
|
I like this idea. I need to get my head around GH triggers before I approve it. |
|
My suggestions here: buildpacks/lifecycle#801 (comment) There may be a better way to do it, feedback is welcome :) |
Signed-off-by: glokta1 <[email protected]>
glokta1
force-pushed
the
build-on-lifecycle-release
branch
from
61761d9 to
26f6efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures sample builders are up-to-date with the lifecycle. See buildpacks/lifecycle#801
Signed-off-by: glokta1 [email protected]
Will update this PR with the script to update
builder.tomlfiles in a bit. I suspect I won't have write permissions to modify files though so I'm a little confused on how to test it...any pointers? 😅. I'm new to testing these workflows