Create 0000-creator-skip-sbom.md #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kritka Sahni <[email protected]>
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
natalieparellano
added
spec/platform
scope/team
Comment on lines
+92
to
+95
| We already support enabling CNB_SKIP_LAYERS in /cnb/lifecycle/analyzer and /cnb/lifecycle/restorer, and CNB_SKIP_RESTORE in /cnb/lifecycle/creator. | ||
| * CNB_SKIP_LAYERS in /cnb/lifecycle/analyzer to skip restoring SBOM from previous app image. | ||
| * CNB_SKIP_LAYERS in /cnb/lifecycle/restorer to skip reusing previous app image layers entirely. | ||
| * CNB_SKIP_RESTORE in /cnb/lifecycle/creator to skips restoring SBOM plus all other layers entirely from previous app image. |
There was a problem hiding this comment.
In the future it might be clearer if there were only two inputs - CNB_SKIP_LAYERS for buildpack layer directories, and CNB_SKIP_SBOM for the SBOM layer. We could deprecate CNB_SKIP_LAYERS in the analyzer and CNB_SKIP_RESTORE in the creator to keep everything consistent. But, that may be more effort than it's worth.
There was a problem hiding this comment.
Yeah - I think CNB_SKIP_RESTORE could be great. I don't want to go wild with options if we think they would likely both be set the same by platforms.
natalieparellano
added
status/ready-for-review
and removed
status/steward-assigned
labels
jabrown85
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@natalieparellano fyi ^^