Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory in Build Config RFC #271

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Update directory in Build Config RFC #271

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55afc0
Update directory in Build Config RFC
AidanDelaney Jan 6, 2023
530ba8c
Update text/0109-build-config.md
AidanDelaney Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions text/0109-build-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# Summary
[summary]: #summary

This RFC proposes an easy way to configure build images to allow specifying a `/cnb/config/env.build` CNB environment directory that allows updating the Buildpack `detect` and `build` environment based on the directory.
This RFC proposes an easy way to configure build images to allow specifying a `/cnb/build-config` CNB environment directory that allows updating the Buildpack `detect` and `build` environment based on the directory.


# Definitions
Expand Down Expand Up @@ -40,10 +40,10 @@ The environment variables may ideally also take precendence over any user provid
# What it is
[what-it-is]: #what-it-is

The RFC proposes the introduction of the following directory `/cnb/config/env.build` in build images. The directory follows the same convention as a `CNB environment directory`. The notable difference is that the environment variables sourced from this directory are applied **AFTER** processing the user-provided platform environment variables i.e. they should have the highest precedence. These variables should be available during both `detect` and `build` phases (and the `generate` phase in the future).
The RFC proposes the introduction of the following directory `/cnb/build-config/env.build` in build images. The directory follows the same convention as a `CNB environment directory`. The notable difference is that the environment variables sourced from this directory are applied **AFTER** processing the user-provided platform environment variables i.e. they should have the highest precedence. These variables should be available during both `detect` and `build` phases (and the `generate` phase in the future).
AidanDelaney marked this conversation as resolved.
Show resolved Hide resolved


The operator can define this directory in the build image under `/cnb/config` or `CNB_CONFIG_DIR` if defined.
The operator can define this directory in the build image under `/cnb/build-config` or `CNB_BUILD_CONFIG_DIR` if defined.

# How it Works
[how-it-works]: #how-it-works
Expand Down Expand Up @@ -119,4 +119,4 @@ N/A
Addition of the definition of the above directory in the Platform specification i.e. -

- `CNB_BUILD_CONFIG_DIR`
- `/cnb/config/env.build`
- `/cnb/build-config/`